Skip to content

delete test_get_metadata test#359

Merged
panchicore merged 1 commit intomainfrom
delete-test_get_metadata
May 23, 2025
Merged

delete test_get_metadata test#359
panchicore merged 1 commit intomainfrom
delete-test_get_metadata

Conversation

@panchicore
Copy link
Member

Internal Notes for Reviewers

  • deleted test_get_metadata as the endpoint was not used in lib.
  • deleted as well from backend

External Release Notes

@github-actions
Copy link
Contributor

PR Summary

This pull request removes an unused test method test_get_metadata from the tests/test_api_client.py file. The test was designed to verify the aget_metadata function of the api_client module, which involved mocking an HTTP GET request to retrieve metadata. The removal suggests that this test is either obsolete or the functionality it was testing is no longer relevant or has been refactored elsewhere.

Test Suggestions

  • Verify that the removal of the test_get_metadata does not affect the overall test coverage.
  • Ensure that any functionality previously covered by test_get_metadata is tested elsewhere if still relevant.
  • Run the full test suite to confirm no other tests are dependent on the removed test.

@AnilSorathiya AnilSorathiya added the internal Not to be externalized in the release notes label May 23, 2025
@panchicore panchicore merged commit a80f6ea into main May 23, 2025
7 of 8 checks passed
@panchicore panchicore deleted the delete-test_get_metadata branch May 23, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants